lkml.org 
[lkml]   [2021]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] genirq: reduce irqdebug bouncing cachelines
Date
On Tue, Apr 13 2021 at 14:16, Cédric Le Goater wrote:
>>> We could test irq_settings_no_debug() directly under handle_nested_irq()
>>> and handle_irq_event_percpu() to avoid calling note_interrupt(), just
>>> like we do for noirqdebug.
>>
>> We can do that, but then we should not just make it:
>>
>> if (!irqnodebug && !irq_settings_no_debug(desc))
>> note_interrupt(...);
>>
>> Instead have only one condition:
>>
>> if (!irq_settings_no_debug(desc))
>> note_interrupt(...);
>>
>> See the uncompiled delta patch below.
>
> I merged this second part with the first and gave IRQF_NO_DEBUG a try
> on P8 and P9 systems and all looked fine. I should send both patches
> after IRQF_NO_AUTOEN is merged in mainline.

Does having that NODEBUG flag set on the IPI irqs make a measurable
difference or is it just too small to matter?

Thanks,

tglx




\
 
 \ /
  Last update: 2021-04-13 22:26    [W:0.086 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site