lkml.org 
[lkml]   [2021]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 071/210] nl80211: fix potential leak of ACL params
    Date
    From: Johannes Berg <johannes.berg@intel.com>

    commit abaf94ecc9c356d0b885a84edef4905cdd89cfdd upstream.

    In case nl80211_parse_unsol_bcast_probe_resp() results in an
    error, need to "goto out" instead of just returning to free
    possibly allocated data.

    Fixes: 7443dcd1f171 ("nl80211: Unsolicited broadcast probe response support")
    Link: https://lore.kernel.org/r/20210408142833.d8bc2e2e454a.If290b1ba85789726a671ff0b237726d4851b5b0f@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/wireless/nl80211.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/wireless/nl80211.c
    +++ b/net/wireless/nl80211.c
    @@ -5,7 +5,7 @@
    * Copyright 2006-2010 Johannes Berg <johannes@sipsolutions.net>
    * Copyright 2013-2014 Intel Mobile Communications GmbH
    * Copyright 2015-2017 Intel Deutschland GmbH
    - * Copyright (C) 2018-2020 Intel Corporation
    + * Copyright (C) 2018-2021 Intel Corporation
    */

    #include <linux/if.h>
    @@ -5401,7 +5401,7 @@ static int nl80211_start_ap(struct sk_bu
    rdev, info->attrs[NL80211_ATTR_UNSOL_BCAST_PROBE_RESP],
    &params);
    if (err)
    - return err;
    + goto out;
    }

    nl80211_calculate_ap_params(&params);

    \
     
     \ /
      Last update: 2021-04-12 11:41    [W:2.351 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site