lkml.org 
[lkml]   [2021]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 105/111] net: ieee802154: fix nl802154 del llsec dev
    Date
    From: Alexander Aring <aahringo@redhat.com>

    commit 3d1eac2f45585690d942cf47fd7fbd04093ebd1b upstream.

    This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is
    not set by the user. If this is the case nl802154 will return -EINVAL.

    Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com
    Signed-off-by: Alexander Aring <aahringo@redhat.com>
    Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com
    Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ieee802154/nl802154.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/ieee802154/nl802154.c
    +++ b/net/ieee802154/nl802154.c
    @@ -1774,7 +1774,8 @@ static int nl802154_del_llsec_dev(struct
    struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1];
    __le64 extended_addr;

    - if (nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack))
    + if (!info->attrs[NL802154_ATTR_SEC_DEVICE] ||
    + nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack))
    return -EINVAL;

    if (!attrs[NL802154_DEV_ATTR_EXTENDED_ADDR])

    \
     
     \ /
      Last update: 2021-04-12 10:59    [W:2.163 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site