lkml.org 
[lkml]   [2021]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] net: phy: marvell: fix detection of PHY on Topaz switches
    On Mon, Apr 12, 2021 at 06:57:39PM +0200, Pali Rohár wrote:
    > Since commit fee2d546414d ("net: phy: marvell: mv88e6390 temperature
    > sensor reading"), Linux reports the temperature of Topaz hwmon as
    > constant -75°C.
    >
    > This is because switches from the Topaz family (88E6141 / 88E6341) have
    > the address of the temperature sensor register different from Peridot.
    >
    > This address is instead compatible with 88E1510 PHYs, as was used for
    > Topaz before the above mentioned commit.
    >
    > Create a new mapping table between switch family and PHY ID for families
    > which don't have a model number. And define PHY IDs for Topaz and Peridot
    > families.
    >
    > Create a new PHY ID and a new PHY driver for Topaz's internal PHY.
    > The only difference from Peridot's PHY driver is the HWMON probing
    > method.
    >
    > Prior this change Topaz's internal PHY is detected by kernel as:
    >
    > PHY [...] driver [Marvell 88E6390] (irq=63)
    >
    > And afterwards as:
    >
    > PHY [...] driver [Marvell 88E6341 Family] (irq=63)
    >
    > Signed-off-by: Pali Rohár <pali@kernel.org>
    > BugLink: https://github.com/globalscaletechnologies/linux/issues/1
    > Fixes: fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading")
    > Reviewed-by: Marek Behún <kabel@kernel.org>

    Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

    \
     
     \ /
      Last update: 2021-04-12 19:46    [W:5.077 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site