Messages in this thread Patch in this message | | | Date | Mon, 12 Apr 2021 15:04:58 +0200 | From | Jessica Yu <> | Subject | Re: [PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG. |
| |
+++ zhouchuangao [30/03/21 05:07 -0700]: >It can be optimized at compile time. > >Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Hi,
Could you please provide a more descriptive changelog? I.e., Is this a fix for a cocinelle warning? What are the optimization(s)?
Thanks,
Jessica
>--- > kernel/module.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/kernel/module.c b/kernel/module.c >index 3047935..f46fc4f 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -1014,8 +1014,8 @@ void __symbol_put(const char *symbol) > }; > > preempt_disable(); >- if (!find_symbol(&fsa)) >- BUG(); >+ BUG_ON(!find_symbol(&fsa)); >+ > module_put(fsa.owner); > preempt_enable(); > } >-- >2.7.4 >
| |