Messages in this thread | | | Date | Sun, 11 Apr 2021 10:39:13 +0200 | From | Greg KH <> | Subject | Re: [Outreachy kernel] [PATCH v3 3/4] staging: rtl8723bs: Change the type and use of a variable |
| |
On Sun, Apr 11, 2021 at 10:29:07AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling expression of an > 'if' statement.
The "shorten" portion should be in patch 4/4 as it does the same thing there, right?
Don't mix the two here, the changing of the type is fine to do alone as a single patch and the if () change has nothing to do with that.
Also, you have trailing whitespace in your changelog text :(
thanks,
greg k-h
| |