Messages in this thread | | | From | Shakeel Butt <> | Date | Sat, 10 Apr 2021 10:48:15 -0700 | Subject | Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack |
| |
On Fri, Apr 9, 2021 at 9:34 PM Muchun Song <songmuchun@bytedance.com> wrote: > > On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner <hannes@cmpxchg.org> wrote: > > > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > > set up pagevec as late as possible in shrink_inactive_list()"), its > > > purpose is to delay the allocation of pagevec as late as possible to > > > save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off > > > reclaim stack") replace pagevecs by lists of pages_to_free. So we do > > > not need noinline_for_stack, just remove it (let the compiler decide > > > whether to inline). > > > > > > Signed-off-by: Muchun Song <songmuchun@bytedance.com> > > > > Good catch. > > > > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > > > > Since this patch is somewhat independent of the rest of the series, > > you may want to put it in the very beginning, or even submit it > > separately, to keep the main series as compact as possible. Reviewers > > can be more hesitant to get involved with larger series ;) > > OK. I will gather all the cleanup patches into a separate series. > Thanks for your suggestion.
That would be best.
For this patch:
Reviewed-by: Shakeel Butt <shakeelb@google.com>
| |