Messages in this thread | | | Date | Sat, 10 Apr 2021 15:23:35 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*' |
| |
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e. boolean expression. This makes code more readable > alternative. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> > --- > Changes from v1:- added pointer to the function, which was missed during > fixing v1. > > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c > index 4457c1acfbf6..78b5b4eaec5f 100644 > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c > @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS, > } > > *ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect); > - if (ppTS) > + if (*ppTS)
This looks like a patch against your previous patch, and not against the original code.
julia
> return true; > > if (!bAddNewTs) { > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHGhdtldqAlRsPHT%40kali. >
| |