Messages in this thread | | | Date | Thu, 1 Apr 2021 11:09:51 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v2 1/2] dt-bindings: iio: temperature: Add DT bindings for TMP117 |
| |
On Thu, Apr 01, 2021 at 02:46:47PM +0530, Puranjay Mohan wrote: > Add devicetree binding document for TMP117, a digital temperature sensor.
Please run checkpatch.pl and fix trailing WS.
> > Signed-off-by: Puranjay Mohan <puranjay12@gmail.com> > --- > .../bindings/iio/temperature/ti,tmp117.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > > diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > new file mode 100644 > index 000000000..1ead22317 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/iio/temperature/ti,tmp117.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: "TI TMP117 - Digital temperature sensor with integrated NV memory" > + > +description: | > + TI TMP117 - Digital temperature sensor with integrated NV memory that supports > + I2C interface. > + https://www.ti.com/lit/gpn/tmp1 > + > +maintainers: > + - "Puranjay Mohan <puranjay12@gmail.com>"
Don't need quotes.
> + > +properties: > + compatible: > + enum: > + - "ti,tmp117"
Don't need quotes.
Blank line here.
> + reg: > + maxItems: 1
blank line here.
> +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + tmp117@48 { > + compatible = "ti,tmp117"; > + reg = <0x48>;
You could just add to trivial-devices.yaml.
> + }; > -- > 2.30.1 >
| |