lkml.org 
[lkml]   [2021]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] KVM: nSVM: improve SYSENTER emulation on AMD
From
Date
On 01/04/21 15:03, Vitaly Kuznetsov wrote:
>> + svm->sysenter_eip_hi = guest_cpuid_is_intel(vcpu) ? (data >> 32) : 0;
>
> (Personal taste) I'd suggest we keep the whole 'sysenter_eip'/'sysenter_esp'
> even if we only use the upper 32 bits of it. That would reduce the code
> churn a little bit (no need to change 'struct vcpu_svm').

Would there really be less changes? Consider that you'd have to look at
the VMCB anyway because svm_get_msr can be reached not just for guest
RDMSR but also for ioctls.

Paolo

\
 
 \ /
  Last update: 2021-04-01 20:08    [W:0.072 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site