Messages in this thread | | | Subject | Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M | From | Matthias Schiffer <> | Date | Thu, 01 Apr 2021 10:06:47 +0200 |
| |
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote: > On Wed, 31 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > > <matthias.schiffer@ew.tq-group.com> wrote: > > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > > > <matthias.schiffer@ew.tq-group.com> wrote: > > > > ... > > > > > > > + return 24000; > > > > > > > > AFAICS it will return 24 MHz for "Unknown" board. Is it okay to be so brave? > > > > > > As noted in the commit message, our hardware developers intend to use > > > 24 MHz for all future x86 SoMs. > > > > What may go wrong in the future?.. (rhetorical question, obviously) > > My preference would be to be explicit. > > Rather than support boards implicitly i.e. by accident. >
How about logging a warning for unknown boards, but still returning 24 MHz?
| |