Messages in this thread | | | Date | Fri, 2 Apr 2021 04:36:45 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 06/30] media: atmel: atmel-isc: extract CSC submodule config into separate function |
| |
Hi Eugen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Eugen-Hristev/media-atmel-atmel-isc-add-support-for-xisc/20210402-024144 base: git://linuxtv.org/media_tree.git master config: arm64-randconfig-r024-20210401 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/16c4afad71c41ecb74d0afff8e7ccc7e868d3cdd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eugen-Hristev/media-atmel-atmel-isc-add-support-for-xisc/20210402-024144 git checkout 16c4afad71c41ecb74d0afff8e7ccc7e868d3cdd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/media/platform/atmel/atmel-sama5d2-isc.c:57:6: warning: no previous prototype for 'isc_sama5d2_config_csc' [-Wmissing-prototypes] 57 | void isc_sama5d2_config_csc(struct isc_device *isc) | ^~~~~~~~~~~~~~~~~~~~~~
vim +/isc_sama5d2_config_csc +57 drivers/media/platform/atmel/atmel-sama5d2-isc.c
56 > 57 void isc_sama5d2_config_csc(struct isc_device *isc) 58 { 59 struct regmap *regmap = isc->regmap; 60 61 /* Convert RGB to YUV */ 62 regmap_write(regmap, ISC_CSC_YR_YG, 0x42 | (0x81 << 16)); 63 regmap_write(regmap, ISC_CSC_YB_OY, 0x19 | (0x10 << 16)); 64 regmap_write(regmap, ISC_CSC_CBR_CBG, 0xFDA | (0xFB6 << 16)); 65 regmap_write(regmap, ISC_CSC_CBB_OCB, 0x70 | (0x80 << 16)); 66 regmap_write(regmap, ISC_CSC_CRR_CRG, 0x70 | (0xFA2 << 16)); 67 regmap_write(regmap, ISC_CSC_CRB_OCR, 0xFEE | (0x80 << 16)); 68 } 69
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |