Messages in this thread | | | Subject | Re: [PATCH 8/9] clk: qcom: gcc-msm8994: Add proper msm8992 support | From | Stephen Boyd <> | Date | Thu, 01 Apr 2021 12:56:10 -0700 |
| |
Quoting Konrad Dybcio (2021-03-12 18:19:17) > diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c > index fae784b4242f..a5b9db7678d1 100644 > --- a/drivers/clk/qcom/gcc-msm8994.c > +++ b/drivers/clk/qcom/gcc-msm8994.c > @@ -2718,13 +2742,57 @@ static const struct qcom_cc_desc gcc_msm8994_desc = { > }; > > static const struct of_device_id gcc_msm8994_match_table[] = { > - { .compatible = "qcom,gcc-msm8994" }, > + { .compatible = "qcom,gcc-msm8992" }, > + { .compatible = "qcom,gcc-msm8994" }, /* V2 and V2.1 */ > {} > }; > MODULE_DEVICE_TABLE(of, gcc_msm8994_match_table); > > static int gcc_msm8994_probe(struct platform_device *pdev) > { > + struct device *dev = &pdev->dev; > + bool is_msm8992; > + > + is_msm8992 = of_device_is_compatible(pdev->dev.of_node, "qcom,gcc-msm8992"); > + > + if (is_msm8992) {
Drop the bool please
if (of_device_is_compatible(pdev->dev.of_node, "qcom,gcc-msm8992")) {
> + /* MSM8992 features less clocks and some have different freq tables */ > + gcc_msm8994_desc.clks[GCC_LPASS_Q6_AXI_CLK] = 0;
Use NULL please.
> + gcc_msm8994_desc.clks[GCC_PCIE_1_AUX_CLK] = 0; > + gcc_msm8994_desc.clks[GCC_PCIE_1_CFG_AHB_CLK] = 0; > + gcc_msm8994_desc.clks[GCC_PCIE_1_MSTR_AXI_CLK] = 0;
| |