lkml.org 
[lkml]   [2021]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller
On Sun, Mar 07, 2021 at 03:05:31PM -0800, Dmitry Torokhov wrote:
> Hi Oleksij,
>
> On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote:
> > +
> > + /* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */
> > + irq_set_status_flags(spi->irq, IRQ_NOAUTOEN);
> > + ret = devm_request_threaded_irq(dev, spi->irq,
> > + NULL,
> > + &tsc2046_adc_irq,
> > + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> > + name, indio_dev);
>
> I'd recommend dropping IRQF_TRIGGER_LOW and only using IRQF_ONESHOT and
> rely on the platform (ACPI, DT) to specify trigger polarity according to
> how device is wired in a given system. In general I believe newer
> drivers should not specify interrupt triggers themselves.

Ok, thx. Sounds good.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2021-03-09 12:32    [W:0.280 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site