lkml.org 
[lkml]   [2021]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] leds: lgm: fix gpiolib dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    Without gpiolib, the driver fails to build:

    drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
    struct gpio_chip chip;
    ^
    include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
    struct gpio_chip;
    ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
    gpiod_set_value(led->gpiod, val);
    ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
    include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
    static inline void gpio_set_value(unsigned gpio, int value)
    ^
    drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
    gpiod_set_value(led->gpiod, 1);
    ^

    Add the dependency in Kconfig.

    Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/leds/blink/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
    index 265b53476a80..6dedc58c47b3 100644
    --- a/drivers/leds/blink/Kconfig
    +++ b/drivers/leds/blink/Kconfig
    @@ -9,6 +9,7 @@ if LEDS_BLINK

    config LEDS_BLINK_LGM
    tristate "LED support for Intel LGM SoC series"
    + depends on GPIOLIB
    depends on LEDS_CLASS
    depends on MFD_SYSCON
    depends on OF
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-03-08 16:32    [W:2.220 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site