lkml.org 
[lkml]   [2021]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence
On Fri 2021-03-05 11:00:10, Joe Lawrence wrote:
> On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> > On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
> > > On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
> > > > s/varibles/variables/
> > > >
> > > > ...and remove leading spaces from a sentence.
> > >
> > > What do you mean 'leading spaces'? Separating two sentences with
> > > one space or two is a matter of personal style, and we do not attempt
> > > to enforce a particular style in the kernel.
> > >
> > The spaces before the "In" .. nor I am imposing anything , it was peter caught
> > and told me that it is hanging ..move it to the next line ..so I did. ..
> >
>
> Initially I thought the same as Matthew, but after inspecting the diff I
> realized it was just a line wrap. Looks fine to me.
>
> > > > Sometimes it may not be convenient or possible to allocate shadow
> > > > variables alongside their parent objects. Or a livepatch fix may
> > > > -require shadow varibles to only a subset of parent object instances. In
> > > > +require shadow variables to only a subset of parent object instances.
> > >
> > > wrong preposition, s/to/for/ ..where???
>
> Hi Bhaskar,
>
> Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to
> update s/shadow variables to only/shadow variables for only/ but knowing
> me, I probably repeated the same phrasing elsewhere. Up to you, thanks.

I could fix these when pushing unless anyone is against it.

> Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

\
 
 \ /
  Last update: 2021-03-08 11:20    [W:0.766 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site