Messages in this thread | | | Date | Tue, 9 Mar 2021 00:35:54 +0100 | From | Krzysztof Wilczyński <> | Subject | Re: [PATCH v4 2/2] nPCI: brcmstb: Use reset/rearm instead of deassert/assert |
| |
Hi,
Thank you for sending the patches over!
> The Brcmstb PCIe RC uses a reset control "rescal" for certain chips. This [...]
A small suggestion: it would be nicer to mention "Broadcom STB" rather than "Brcmstb" in the sentence above.
[...] > +err1: > + reset_control_rearm(pcie->rescal); > +err0: > clk_disable_unprepare(pcie->clk); > return ret; [...]
A small nitpick. Now that there are two labels on the error recovery path, it might be better to name both of these labels a little bit better. Some examples from the PCI tree:
error_clock_unprepare err_disable_clock err_disable_clk err_clk_disable
So it could be:
err_reset: <-- or err_rearm or even err_reset_rearm, etc. reset_control_rearm(pcie->rescal); err_disable_clk: clk_disable_unprepare(pcie->clk);
What do you think?
Krzysztof
| |