Messages in this thread | | | Date | Mon, 8 Mar 2021 09:03:54 +0100 | From | Marco Felsch <> | Subject | Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor |
| |
Hi Teresa, Heiko,
On 21-03-08 07:46, Teresa Remmet wrote: > Hello Heiko, > > first thanks for the patch :). > > Am Montag, den 08.03.2021, 07:40 +0100 schrieb Heiko Schocher: > > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > > > Signed-off-by: Heiko Schocher <hs@denx.de> > > --- > > > > .../dts/freescale/imx8mp-phycore-som.dtsi | 27 > > +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > > index 44a8c2337cee4..0284e7a5c6bba 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > > @@ -65,6 +65,22 @@ ethphy1: ethernet-phy@0 { > > }; > > }; > > > > +&flexspi { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_flexspi0>; > > + status = "okay"; > > + > > + flash0: mt25qu256aba@0 { > > you can remove the label. As it is not used here right now.
I would keep the label since most the time the bootloaders will fixup the device tree because they adding a of-partition to it. It's mostly just a matter of time.
> Also rename the node name to device type like "flash" maybe.
+1
I would name it 'som_flash: flash@0 { }'
Regards, Marco
| |