Messages in this thread | | | Subject | Re: [PATCH AUTOSEL 5.11 09/12] nvme-pci: mark Kingston SKC2000 as not supporting the deepest power state | From | Böszörményi Zoltán <> | Date | Sun, 7 Mar 2021 16:00:15 +0100 |
| |
Hi,
2021. 03. 07. 14:57 keltezéssel, Sasha Levin írta: > From: Zoltán Böszörményi <zboszor@gmail.com> > > [ Upstream commit dc22c1c058b5c4fe967a20589e36f029ee42a706 ] > > My 2TB SKC2000 showed the exact same symptoms that were provided > in 538e4a8c57 ("nvme-pci: avoid the deepest sleep state on > Kingston A2000 SSDs"), i.e. a complete NVME lockup that needed > cold boot to get it back. > > According to some sources, the A2000 is simply a rebadged > SKC2000 with a slightly optimized firmware. > > Adding the SKC2000 PCI ID to the quirk list with the same workaround > as the A2000 made my laptop survive a 5 hours long Yocto bootstrap > buildfest which reliably triggered the SSD lockup previously. > > Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Sasha Levin <sashal@kernel.org>
Thanks for picking it up for stable.
May I suggest to include it in 5.10.x as well? Originally this patch was tested on 5.10.17.
Best regards, Zoltán Böszörményi
> --- > drivers/nvme/host/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index 7a38d764b486..14c5b52400ef 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -3262,6 +3262,8 @@ static const struct pci_device_id nvme_id_table[] = { > .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, > { PCI_DEVICE(0x1d97, 0x2263), /* SPCC */ > .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, > + { PCI_DEVICE(0x2646, 0x2262), /* KINGSTON SKC2000 NVMe SSD */ > + .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, > { PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */ > .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
| |