lkml.org 
[lkml]   [2021]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] MIPS: Loongson64: Move loongson system con figuration to loongson.h


    On Sat, Mar 6, 2021, at 5:53 PM, Thomas Bogendoerfer wrote:
    > On Sat, Mar 06, 2021 at 05:00:15PM +0800, Jiaxun Yang wrote:
    > >
    > >
    > > On Sat, Mar 6, 2021, at 4:03 PM, Thomas Bogendoerfer wrote:
    > > > On Thu, Mar 04, 2021 at 07:00:57PM +0800, Qing Zhang wrote:
    > > > > The purpose of separating loongson_system_configuration from boot_param.h
    > > > > is to keep the other structure consistent with the firmware.
    > > > >
    > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
    > > > > Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
    > > > > ---
    > > > > .../include/asm/mach-loongson64/boot_param.h | 18 ------------------
    > > > > .../include/asm/mach-loongson64/loongson.h | 18 ++++++++++++++++++
    > > >
    > > > as you are already touching mach-loongson64 files...
    > > >
    > > > Is there a chance you clean up that up even further ? My goal is to
    > > > have only files in mach-<platform> files, which have an mach-generic
    > > > counterpart. Everything else should go to its own directory. So in
    > > > case of loongson something
    > > >
    > > > like
    > > >
    > > > arch/mips/include/asm/loongson for common stuff
    > > > arch/mips/include/asm/loongson/32
    > > > arch/mips/include/asm/loongson/64
    > >
    > > Hi Thomas
    > >
    > > I'm object to this idea as loongson32/2ef/64 have nothing in common.
    >
    > at least they share the name loongson, so having
    >
    > arch/mips/include/asm/loongson
    >
    > sounds like a good move.
    >
    > And seeing
    >
    > diff -u mach-loongson2ef/ mach-loongson64/loongson.h | diffstat
    > loongson.h | 137 +++++++++++++------------------------------------------------
    > 1 file changed, 30 insertions(+), 107 deletions(-)
    >
    > wc mach-loongson2ef/loongson.h
    > 318 963 11278 mach-loongson2ef/loongson.h
    >
    > so there is something to shared. To me it looks like 2ef could be merged
    > into 64, but that's nothing I'm wanting.

    Hmm there are duplications in loongson.h just because we didn't clean them up when splitting loongson2ef out of loongson64.

    >
    > Just to understand you, you want
    >
    > arch/mips/include/asm/loongson/2ef
    > arch/mips/include/asm/loongson/32
    > arch/mips/include/asm/loongson/64

    Yeah it looks reasonable but from my point of view doing these movement brings no actual benefit :-(

    Thanks.

    - Jiaxun

    >
    > ?
    >
    > Thomas.
    >
    > --
    > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
    > good idea. [ RFC1925, 2.3 ]
    >

    --
    - Jiaxun

    \
     
     \ /
      Last update: 2021-03-06 11:57    [W:2.833 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site