lkml.org 
[lkml]   [2021]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] input: s6sy761: fix coordinate read bit shift
Hi Caleb,

On Fri, Mar 05, 2021 at 06:58:10PM +0000, Caleb Connolly wrote:
> The touch coordinate register contains the following:
>
> byte 3 byte 2 byte 1
> +--------+--------+ +-----------------+ +-----------------+
> | | | | | | |
> | X[3:0] | Y[3:0] | | Y[11:4] | | X[11:4] |
> | | | | | | |
> +--------+--------+ +-----------------+ +-----------------+
>
> Bytes 2 and 1 need to be shifted left by 4 bits, the least significant
> nibble of each is stored in byte 3. Currently they are only
> being shifted by 3 causing the reported coordinates to be incorrect.
>
> This matches downstream examples, and has been confirmed on my
> device (OnePlus 7 Pro).
>
> Fixes: 0145a7141e59 ("Input: add support for the Samsung S6SY761
> touchscreen")
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>

Reviewed-by: Andi Shyti <andi@etezian.org>

Thanks,
Andi

\
 
 \ /
  Last update: 2021-03-06 11:43    [W:0.038 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site