Messages in this thread | | | Subject | Re: [PATCH] arm64: dts: qcom: Introduce SM8350 HDK | From | Konrad Dybcio <> | Date | Sat, 6 Mar 2021 11:34:12 +0100 |
| |
Hi!
> + vreg_l5b_0p88: ldo5 { > + regulator-name = "vreg_l5b_0p88"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <888000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + }; > +
This one needs `regulator-allow-set-load` since you specify current settings under UFS nodes, we've seen it not working at all without this property.
> + vreg_l6b_1p2: ldo6 { > + regulator-name = "vreg_l6b_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1208000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l7b_2p96: ldo7 { > + regulator-name = "vreg_l7b_2p96"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2504000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l9b_1p2: ldo9 { > + regulator-name = "vreg_l9b_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + };
Ditto for all three
> +&usb_1_dwc3 { > + /* TODO: Define USB-C connector properly */
Sidenote: doesn't the new pm8150x (I think?) USB-C driver work on pm8350x?
> +/* PINCTRL - additions to nodes defined in sdm845.dtsi */
sm8350
Aside from these minor comments,
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
| |