Messages in this thread | | | Subject | Re: [PATCH 2/2 v2] usb: gadget: s3c: Fix the error handling path in 's3c2410_udc_probe()' | From | Christophe JAILLET <> | Date | Sat, 6 Mar 2021 18:22:48 +0100 |
| |
Le 06/03/2021 à 17:16, Krzysztof Kozlowski a écrit : > On 06/03/2021 15:21, Christophe JAILLET wrote: >> Some 'clk_prepare_enable()' and 'clk_get()' must be undone in the error >> handling path of the probe function, as already done in the remove >> function. >> >> Fixes: 3fc154b6b813 ("USB Gadget driver for Samsung s3c2410 ARM SoC") >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> --- >> v2: Fix a stupid error in the hash in Fixes: >> --- >> drivers/usb/gadget/udc/s3c2410_udc.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) >> > > Do not ignore received tags but add them before sending a new version of patch. > https://lore.kernel.org/linux-samsung-soc/36ef897b-aedc-fcc3-89c8-c602d9733a9b@canonical.com/T/#t > > Also somehow your 2nd patch is not in-reply to first one. Don't change > the settings of sending patches. git format-patch and > git send-email default settings are correct. Look here: > https://lore.kernel.org/linux-samsung-soc/ > Only your patches are not threaded. > > Best regards, > Krzysztof > Hi,
sorry for missing the typo in the first patch.
For your other comments above, however, I use standard settings only. My patches are generated by commands like: git format-patch -2
I use cover letter only if it looks useful. In such a case, I use: git format-patch --thread --cover-letter -2
I've never seen that threading series was the rule and/or that cover letters were a must have. If I'm wrong, sorry, I was not aware of that.
I'll also add the "Reviewed-by:" tag.
Thx for the review and explanations.
CJ
| |