lkml.org 
[lkml]   [2021]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.10 083/102] scsi: iscsi: Restrict sessions and handles to admin capabilities
    Hi!

    > From: Lee Duncan <lduncan@suse.com>
    >
    > commit 688e8128b7a92df982709a4137ea4588d16f24aa upstream.
    >
    > Protect the iSCSI transport handle, available in sysfs, by requiring
    > CAP_SYS_ADMIN to read it. Also protect the netlink socket by restricting
    > reception of messages to ones sent with CAP_SYS_ADMIN. This disables
    > normal users from being able to end arbitrary iSCSI sessions.

    Should not normal filesystem permissions be used?

    > +++ b/drivers/scsi/scsi_transport_iscsi.c
    > @@ -132,6 +132,9 @@ show_transport_handle(struct device *dev
    > char *buf)
    > {
    > struct iscsi_internal *priv = dev_to_iscsi_internal(dev);
    > +
    > + if (!capable(CAP_SYS_ADMIN))
    > + return -EACCES;
    > return sprintf(buf, "%llu\n", (unsigned long long)iscsi_handle(priv->iscsi_transport));
    > }
    > static DEVICE_ATTR(handle, S_IRUGO, show_transport_handle, NULL);

    AFAICT we make the file 0444 (world readable) and then fail the read
    with capability check. If the file is not supposed to be
    world-readable, it should have 0400 permissions, right?

    Best regards,
    Pavel
    --
    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-03-05 23:43    [W:4.793 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site