| Date | Thu, 4 Mar 2021 18:49:08 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 17/21] tools/objtool: Convert to insn_decode() |
| |
On Thu, Mar 04, 2021 at 06:42:33PM +0100, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > Simplify code, no functional changes. > > Signed-off-by: Borislav Petkov <bp@suse.de> > --- > tools/objtool/arch/x86/decode.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c > index 549813cff8ab..8380d0b1d933 100644 > --- a/tools/objtool/arch/x86/decode.c > +++ b/tools/objtool/arch/x86/decode.c > @@ -90,7 +90,7 @@ int arch_decode_instruction(const struct elf *elf, const struct section *sec, > struct list_head *ops_list) > { > struct insn insn; > - int x86_64, sign; > + int x86_64, sign, ret; > unsigned char op1, op2, rex = 0, rex_b = 0, rex_r = 0, rex_w = 0, > rex_x = 0, modrm = 0, modrm_mod = 0, modrm_rm = 0, > modrm_reg = 0, sib = 0;
This is going to have trivial rejects/fuzz against tip/objtool/core.
|