Messages in this thread | | | Date | Thu, 4 Mar 2021 14:59:28 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 06/12] lib: bitmap: order includes alphabetically |
| |
On Thu, Mar 04, 2021 at 11:24:46AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > For better readability and maintenance: order the includes in bitmap > source files alphabetically.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > include/linux/bitmap.h | 4 ++-- > lib/bitmap.c | 9 +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index 6939a8983026..3282db97e06c 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -4,10 +4,10 @@ > > #ifndef __ASSEMBLY__ > > -#include <linux/types.h> > #include <linux/bitops.h> > -#include <linux/string.h> > #include <linux/kernel.h> > +#include <linux/string.h> > +#include <linux/types.h> > > /* > * bitmaps provide bit arrays that consume one or more unsigned > diff --git a/lib/bitmap.c b/lib/bitmap.c > index 75006c4036e9..78f70d9007ad 100644 > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -3,17 +3,18 @@ > * lib/bitmap.c > * Helper functions for bitmap.h. > */ > -#include <linux/export.h> > -#include <linux/thread_info.h> > -#include <linux/ctype.h> > -#include <linux/errno.h> > + > #include <linux/bitmap.h> > #include <linux/bitops.h> > #include <linux/bug.h> > +#include <linux/ctype.h> > +#include <linux/errno.h> > +#include <linux/export.h> > #include <linux/kernel.h> > #include <linux/mm.h> > #include <linux/slab.h> > #include <linux/string.h> > +#include <linux/thread_info.h> > #include <linux/uaccess.h> > > #include <asm/page.h> > -- > 2.29.1 >
-- With Best Regards, Andy Shevchenko
| |