lkml.org 
[lkml]   [2021]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] gpio: aggregator: Replace custom get_arg() with a generic next_arg()
On Thu, Mar 04, 2021 at 10:01:46AM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Mon, Mar 1, 2021 at 5:59 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > cmdline library provides next_arg() helper to traverse over parameters
> > and their values given in command line. Replace custom approach in the driver
> > by it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks for your patch!
>
> > --- a/drivers/gpio/gpio-aggregator.c
> > +++ b/drivers/gpio/gpio-aggregator.c
> > @@ -93,13 +68,9 @@ static int aggr_parse(struct gpio_aggregator *aggr)
> > if (!bitmap)
> > return -ENOMEM;
> >
> > - for (name = get_arg(&args), offsets = get_arg(&args); name;
> > - offsets = get_arg(&args)) {
> > - if (IS_ERR(name)) {
> > - pr_err("Cannot get GPIO specifier: %pe\n", name);
> > - error = PTR_ERR(name);
> > - goto free_bitmap;
> > - }
> > + args = next_arg(args, &name, &p);
> > + while (*args) {
> > + args = next_arg(args, &offsets, &p);
>
> As name and offsets should not contain equal signs (can they?),
> I guess using next_arg() is fine.

Even though we can use double quotes (AFAICU the next_arg() code).

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-03-04 12:03    [W:0.058 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site