Messages in this thread | | | Subject | Re: [PATCH] drm/stm: ltdc: Use simple encoder | From | Thomas Zimmermann <> | Date | Thu, 4 Mar 2021 09:21:05 +0100 |
| |
Hi,
shall I merge this patch?
Am 02.03.21 um 18:57 schrieb Jagan Teki: > STM ltdc driver uses an empty implementation for its encoder. > Replace the code with the generic simple encoder. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/gpu/drm/stm/ltdc.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 7812094f93d6..aeeb43524ca0 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -31,6 +31,7 @@ > #include <drm/drm_of.h> > #include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_simple_kms_helper.h> > #include <drm/drm_vblank.h> > > #include <video/videomode.h> > @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc) > return ret; > } > > -/* > - * DRM_ENCODER > - */ > - > -static const struct drm_encoder_funcs ltdc_encoder_funcs = { > - .destroy = drm_encoder_cleanup, > -}; > - > static void ltdc_encoder_disable(struct drm_encoder *encoder) > { > struct drm_device *ddev = encoder->dev; > @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge) > encoder->possible_crtcs = CRTC_MASK; > encoder->possible_clones = 0; /* No cloning support */ > > - drm_encoder_init(ddev, encoder, <dc_encoder_funcs, > - DRM_MODE_ENCODER_DPI, NULL); > + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI); > > drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs); > >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
[unhandled content-type:application/pgp-signature] | |