Messages in this thread | | | From | Josh Don <> | Date | Thu, 4 Mar 2021 17:04:51 -0800 | Subject | Re: [PATCH v2] sched: Optimize __calc_delta. |
| |
On Thu, Mar 4, 2021 at 9:34 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > > Hi Josh, Thanks for helping get this patch across the finish line. > Would you mind updating the commit message to point to > https://bugs.llvm.org/show_bug.cgi?id=20197?
Sure thing, just saw that it got marked as a dup.
Peter, since you've already pulled the patch, can you modify the commit message directly? Nick also recommended dropping the punctuation in the commit oneline.
> > #include <linux/binfmts.h> > > +#include <linux/bitops.h> > > This hunk of the patch is curious. I assume that bitops.h is needed > for fls(); if so, why not #include it in kernel/sched/fair.c? > Otherwise this potentially hurts compile time for all TUs that include > kernel/sched/sched.h.
bitops.h is already included in sched.h via another include, so this was just meant to make it more explicit. Motivation for putting it here vs. fair.c was 325ea10c080940.
| |