Messages in this thread | | | Subject | Re: [PATCH -next] powerpc/eeh: Remove unused inline function eeh_dev_phb_init_dynamic() | From | YueHaibing <> | Date | Wed, 31 Mar 2021 20:58:42 +0800 |
| |
On 2021/3/26 13:08, Daniel Axtens wrote: > Hi, > >> commit 475028efc708 ("powerpc/eeh: Remove eeh_dev_phb_init_dynamic()") >> left behind this, so can remove it. > > I had a look: the inline that you are removing here is for the > !CONFIG_EEH case, which explains why it was missed the first time. > > This looks like a good change. Out of interest, what tool are you using > to find these unused inlines? If there are many more, it might make > sense to combine future patches removing them into a single patch, but > I'm not sure.
Just use some grep skill, will do that if any.
> > checkpatch likes this patch, so that's also good :) > > Reviewed-by: Daniel Axtens <dja@axtens.net> > > Kind regards, > Daniel > . >
| |