lkml.org 
[lkml]   [2021]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] docs: gpio: mockup: Fix parameter name
    Hello Andy,

    Am Wed, Mar 31, 2021 at 03:27:05PM +0300 schrieb Andy Shevchenko:
    > On Mon, Mar 29, 2021 at 2:18 PM Alexander Dahl <ada@thorsis.com> wrote:
    > >
    > > Module probing with the parameter documented yielded this in kernel log:
    > >
    > > gpio_mockup: unknown parameter 'gpio_named_lines' ignored
    > >
    > > The parameter documented did not match the parameter actually
    > > implemented with commit 8a68ea00a62e ("gpio: mockup: implement naming
    > > the lines") long before introducing the documentation.
    > >
    > > Fixes: commit 2fd1abe99e5f ("Documentation: gpio: add documentation for gpio-mockup")
    >
    > Alexander, in the entire series you are using the wrong format for the
    > Fixes tag.
    > I highly recommend to add in your .gitconfig file an alias:
    > one = show -s --pretty='format:%h (\"%s\")'

    You're right. Sorry, I messed things up. I first had that line without
    the additional "commit", and added it because I thought checkpatch
    complained (which it probably did not).

    The actual format is documented of course:

    https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

    I actually have a slightly different setting for pretty.fixes in my
    ~/.gitconfig for other demands. I'll go and make that project
    dependent now.

    Thanks for pointing this out.

    Greets
    Alex

    >
    > `git one <commit ID>` will give you proper value to refer to the
    > commit in question.
    >
    > --
    > With Best Regards,
    > Andy Shevchenko

    \
     
     \ /
      Last update: 2021-03-31 14:55    [W:3.088 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site