lkml.org 
[lkml]   [2021]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/4] MIPS: kernel: Remove not needed set_fs calls
    Date
    flush_icache_range always does flush kernel address ranges, so no
    need to do the set_fs dance.

    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    ---
    arch/mips/kernel/ftrace.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
    index 666b9969c1bd..8c401e42301c 100644
    --- a/arch/mips/kernel/ftrace.c
    +++ b/arch/mips/kernel/ftrace.c
    @@ -90,7 +90,6 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1,
    unsigned int new_code2)
    {
    int faulted;
    - mm_segment_t old_fs;

    safe_store_code(new_code1, ip, faulted);
    if (unlikely(faulted))
    @@ -102,10 +101,7 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1,
    return -EFAULT;

    ip -= 4;
    - old_fs = get_fs();
    - set_fs(KERNEL_DS);
    flush_icache_range(ip, ip + 8);
    - set_fs(old_fs);

    return 0;
    }
    @@ -114,7 +110,6 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1,
    unsigned int new_code2)
    {
    int faulted;
    - mm_segment_t old_fs;

    ip += 4;
    safe_store_code(new_code2, ip, faulted);
    @@ -126,10 +121,7 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1,
    if (unlikely(faulted))
    return -EFAULT;

    - old_fs = get_fs();
    - set_fs(KERNEL_DS);
    flush_icache_range(ip, ip + 8);
    - set_fs(old_fs);

    return 0;
    }
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-03-31 13:58    [W:5.124 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site