Messages in this thread | | | Date | Wed, 31 Mar 2021 13:41:19 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 3/3] MIPS: Remove get_fs/set_fs |
| |
On Tue, Mar 30, 2021 at 07:54:17PM +0200, Christoph Hellwig wrote: > > - if (likely(access_ok( __gu_ptr, size))) { \ > > - if (eva_kernel_access()) \ > > - __get_kernel_common((x), size, __gu_ptr); \ > > FYI, it might be a good idea to fold __{get,put}_kernel_common into > __{get,put}_kernel_nofault now that these are the only callers left.
__get_data macro used it, but I rewrote it, so I could fold in __get/__put_kernel_common.
> Similarly __get_user_common and __put_user_common should probably also > go away.
__get_user_common is used 3 times and __put_user_common twice. So I left them as they are.
> > static inline unsigned long > > raw_copy_to_user(void __user *to, const void *from, unsigned long n) > > { > > + return __invoke_copy_to_user(to, from, n); > > I think __invoke_copy_to_user, __invoke_copy_from_user and > ___invoke_copy_in_user can go away now as well.
done.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |