Messages in this thread | | | Date | Wed, 31 Mar 2021 12:48:20 +0200 | From | Greg KH <> | Subject | Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c |
| |
On Wed, Mar 31, 2021 at 12:36:31PM +0200, Fabio Aiuto wrote: > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > replace private macro RT_TRACE for tracing with in-kernel > > > pr_* printk wrappers > > > > > > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> > > > --- > > > drivers/staging/rtl8723bs/core/rtw_eeprom.c | 26 ++++++++++----------- > > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/core/rtw_eeprom.c > > > index 3cbd65dee741..6176d741d60e 100644 > > > --- a/drivers/staging/rtl8723bs/core/rtw_eeprom.c > > > +++ b/drivers/staging/rtl8723bs/core/rtw_eeprom.c > > > @@ -36,7 +36,7 @@ void shift_out_bits(_adapter *padapter, u16 data, u16 count) > > > _func_enter_; > > > > > > if (padapter->bSurpriseRemoved == true) { > > > - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); > > I looked at this ---------------------------------------^ > and so I thought that pr_err was good...
But you missed the fact that RT_TRACE() does not always spit this stuff out.
And I don't know what _drv_err_ is, but tracing messages should never go to an error log :)
> my aim was remove private macros replicating component tracing and log levels...
That's a great goal!
> so what's best? Keep a simplyfied RT_TRACE encapsulating a dev_* call?
replace them with dev_dbg() is one way, if they really are even needed at all. At this point in time, I would strongly just recommend removing them all as no one is using them for anything.
thanks,
greg k-h
| |