Messages in this thread | | | From | Matthias Brugger <> | Subject | Re: [PATCH v2 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD | Date | Wed, 31 Mar 2021 12:48:00 +0200 |
| |
On 01/02/2021 13:14, Bilal Wasim wrote: > The mfg_async power domain in mt8173 is used to power up imgtec > gpu. This domain requires the da9211 regulator to be enabled before > the power domain can be enabled successfully. > > Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com> > Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > drivers/soc/mediatek/mt8173-pm-domains.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/soc/mediatek/mt8173-pm-domains.h > index 3e8ee5dabb43..065b8195e7d6 100644 > --- a/drivers/soc/mediatek/mt8173-pm-domains.h > +++ b/drivers/soc/mediatek/mt8173-pm-domains.h > @@ -63,6 +63,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8173[] = { > .ctl_offs = SPM_MFG_ASYNC_PWR_CON, > .sram_pdn_bits = GENMASK(11, 8), > .sram_pdn_ack_bits = 0, > + .caps = MTK_SCPD_DOMAIN_SUPPLY,
Hm, I think the problem here is, that we don't find the regulator "domain-supply" in the DTS. And that provokes that we error out on all power domains. Not sure if we should fix that somehow, so that a missing regulator will only affect one power domain (and it's childs).
Regards, Matthias
> }, > [MT8173_POWER_DOMAIN_MFG_2D] = { > .sta_mask = PWR_STATUS_MFG_2D, >
| |