Messages in this thread | | | Date | Wed, 31 Mar 2021 10:35:55 +0100 | From | Lorenzo Pieralisi <> | Subject | Re: [PATCH] PCI: xgene: fix a mistake about cfg address |
| |
On Tue, Mar 30, 2021 at 02:19:26PM -0500, Bjorn Helgaas wrote: > On Sun, Mar 28, 2021 at 10:41:18PM +0800, Dejin Zheng wrote: > > It has a wrong modification to the xgene driver by the commit > > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > > simplify codes and remove the res variable, But the following code > > needs to use this res variable, So after this commit, the port->cfg_addr > > will get a wrong address. Now, revert it. > > > > Fixes: e2dcd20b1645a ("PCI: controller: Convert to devm_platform_ioremap_resource_byname()") > > Reported-by: dann.frazier@canonical.com > > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> > > This looks right to me, but since e2dcd20b1645a appeared in v5.9-rc1, > I think it should have: > > Cc: stable@vger.kernel.org # v5.9+
Fixed and pushed out in my pci/xgene branch.
Thanks, Lorenzo
| |