lkml.org 
[lkml]   [2021]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] powerpc/traps: Enhance readability for trap types
Date
Segher Boessenkool <segher@kernel.crashing.org> writes:
> On Wed, Mar 31, 2021 at 08:58:17PM +1100, Michael Ellerman wrote:
>> So perhaps:
>>
>> EXC_SYSTEM_RESET
>> EXC_MACHINE_CHECK
>> EXC_DATA_STORAGE
>> EXC_DATA_SEGMENT
>> EXC_INST_STORAGE
>> EXC_INST_SEGMENT
>> EXC_EXTERNAL_INTERRUPT
>> EXC_ALIGNMENT
>> EXC_PROGRAM_CHECK
>> EXC_FP_UNAVAILABLE
>> EXC_DECREMENTER
>> EXC_HV_DECREMENTER
>> EXC_SYSTEM_CALL
>> EXC_HV_DATA_STORAGE
>> EXC_PERF_MONITOR
>
> These are interrupt (vectors), not exceptions. It doesn't matter all
> that much, but confusing things more isn't useful either! There can be
> multiple exceptions that all can trigger the same interrupt.

Yeah I know, but I think that ship has already sailed as far as the
naming we have in the kernel.

We have over 250 uses of "exc", and several files called "exception"
something.

Using "interrupt" can also be confusing because Linux uses that to mean
"external interrupt".

But I dunno, maybe INT or VEC is clearer? .. or TRAP :)

cheers

\
 
 \ /
  Last update: 2021-04-01 04:41    [W:0.096 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site