lkml.org 
[lkml]   [2021]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 08/10] x86/entry: Preserve PKRS MSR across exceptions
On Wed, Mar 31, 2021 at 12:31:56PM -0700, Dave Hansen wrote:
> On 3/31/21 12:14 PM, ira.weiny@intel.com wrote:
> > + * To protect against exceptions having access to this memory we save the
> > + * current running value and sets the PKRS value to be used during the
> > + * exception.
>
> This series seems to have grown some "we's".

I suppose it has...

>
> The preexisting pkey code was not innocent in this regard, either. But,
> please fix this up across the series in the next submission. Literally
> removing "we" from this sentence doesn't change the meaning at all.

Sure I can audit the series for this... Waiting a day for other comments.

Thanks,
Ira

\
 
 \ /
  Last update: 2021-04-01 03:17    [W:0.040 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site