Messages in this thread | | | Subject | Re: [PATCH v2] nvme-tcp: Check if request has started before processing it | From | Sagi Grimberg <> | Date | Wed, 31 Mar 2021 15:24:49 -0700 |
| |
>> What we can do, though, is checking the 'state' field in the tcp >> request, and only allow completions for commands which are in a state >> allowing for completions. >> >> Let's see if I can whip up a patch. > > That would be great. BTW in the crash dump I am looking at now, it > looks like pdu->command_id was zero in nvme_tcp_recv_data(), and > blk_mq_tag_to_rq() returned a request struct that had not been used. > So I think we do need to check that the tag was actually allocated.
request tag can't be zero? I forget...
| |