lkml.org 
[lkml]   [2021]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] Adding i2c-cp2615: i2c support for Silicon Labs' CP2615 Digital Audio Bridge

> > drivers/i2c/busses/i2c-cp2615.c:78:5: warning: symbol 'cp2615_init_iop_msg' was not declared. Should it be static?
> > drivers/i2c/busses/i2c-cp2615.c:96:5: warning: symbol 'cp2615_init_i2c_msg' was not declared. Should it be static?
> > drivers/i2c/busses/i2c-cp2615.c:102:5: warning: symbol 'cp2615_check_status' was not declared. Should it be static?
> I can forward declare these (copying from the header I used in v1 of
> the patch), but I'm not sure I understand the rationale behind these
> warnings...

Just make them static and all is good.

> > drivers/i2c/busses/i2c-cp2615.c:212:27: warning: symbol 'cp2615_i2c_quirks' was not declared. Should it be static?
> Especially this. I think I will make this static instead, since it
> won't ever be exported to any other module.

Exactly.

> > The missing 'static' are what buildbot also reported and are correct.
> The lkp bot complained about MODULE_DEVICE_TABLE and MODULE_AUTHOR,
> which, again, I don't see what is wrong with it.

Yeah, that may be a false positive.

> I will now send an updated patch, with few additions too.

Cool, thanks!

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-31 22:56    [W:0.059 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site