Messages in this thread Patch in this message | | | From | Lee Jones <> | Subject | [PATCH 04/31] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others | Date | Tue, 30 Mar 2021 17:44:31 +0100 |
| |
Fixes the following W=1 kernel build warning(s):
fs/gfs2/glops.c:58: warning: Function parameter or member 'nr_revokes' not described in '__gfs2_ail_flush' fs/gfs2/glops.c:490: warning: Function parameter or member 'gh' not described in 'inode_go_lock' fs/gfs2/glops.c:490: warning: Excess function parameter 'gl' description in 'inode_go_lock' fs/gfs2/glops.c:490: warning: Excess function parameter 'flags' description in 'inode_go_lock' fs/gfs2/glops.c:532: warning: Function parameter or member 'gl' not described in 'inode_go_dump' fs/gfs2/glops.c:532: warning: Excess function parameter 'ip' description in 'inode_go_dump' fs/gfs2/glops.c:562: warning: Excess function parameter 'state' description in 'freeze_go_sync' fs/gfs2/glops.c:562: warning: Excess function parameter 'flags' description in 'freeze_go_sync' fs/gfs2/glops.c:607: warning: Function parameter or member 'gh' not described in 'freeze_go_xmote_bh' fs/gfs2/glops.c:640: warning: expecting prototype for trans_go_demote_ok(). Prototype was for freeze_go_demote_ok() instead fs/gfs2/glops.c:651: warning: Function parameter or member 'remote' not described in 'iopen_go_callback'
Cc: Bob Peterson <rpeterso@redhat.com> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones <lee.jones@linaro.org> --- fs/gfs2/glops.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index ef0b583c3417c..5711b2c8de9e2 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -49,6 +49,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh) * __gfs2_ail_flush - remove all buffers for a given lock from the AIL * @gl: the glock * @fsync: set when called from fsync (not all buffers will be clean) + * @nr_revokes: Number of buffers to revoke * * None of the buffers should be dirty, locked, or pinned. */ @@ -478,10 +479,8 @@ int gfs2_inode_refresh(struct gfs2_inode *ip) return error; } -/** +/* * inode_go_lock - operation done after an inode lock is locked by a process - * @gl: the glock - * @flags: * * Returns: errno */ @@ -522,7 +521,7 @@ static int inode_go_lock(struct gfs2_holder *gh) /** * inode_go_dump - print information about an inode * @seq: The iterator - * @ip: the inode + * @gl: The glock * @fs_id_buf: file system id (may be empty) * */ @@ -553,9 +552,6 @@ static void inode_go_dump(struct seq_file *seq, struct gfs2_glock *gl, /** * freeze_go_sync - promote/demote the freeze glock * @gl: the glock - * @state: the requested state - * @flags: - * */ static int freeze_go_sync(struct gfs2_glock *gl) @@ -597,12 +593,10 @@ static int freeze_go_sync(struct gfs2_glock *gl) return 0; } -/** +/* * freeze_go_xmote_bh - After promoting/demoting the freeze glock * @gl: the glock - * */ - static int freeze_go_xmote_bh(struct gfs2_glock *gl, struct gfs2_holder *gh) { struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; @@ -630,7 +624,7 @@ static int freeze_go_xmote_bh(struct gfs2_glock *gl, struct gfs2_holder *gh) } /** - * trans_go_demote_ok + * freeze_go_demote_ok() * @gl: the glock * * Always returns 0 @@ -641,7 +635,7 @@ static int freeze_go_demote_ok(const struct gfs2_glock *gl) return 0; } -/** +/* * iopen_go_callback - schedule the dcache entry for the inode to be deleted * @gl: the glock * -- 2.27.0
| |