Messages in this thread | | | Subject | Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version | From | Richard Gong <> | Date | Tue, 30 Mar 2021 11:02:46 -0500 |
| |
Hi David,
On 3/30/21 9:19 AM, David Laight wrote: > From: richard.gong@linux.intel.com >> Sent: 30 March 2021 15:33 >> >> Extend Intel service layer driver to get the firmware version running at >> FPGA device. Therefore FPGA manager driver, one of Intel service layer >> driver's client, can decide whether to handle the newly added bitstream >> authentication function based on the retrieved firmware version. > > Using the version number to detect features is just plain wrong. > > You should use something like a bitmap of supported features.
Firmware, which runs at EL3, returns the version to Intel service layer driver in a 64-bit value at the register. Intel service layer driver runs at EL1.
Regards, Richard
> > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) >
| |