Messages in this thread | | | Date | Tue, 30 Mar 2021 16:35:34 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver |
| |
On Tue, Mar 30, 2021 at 09:12:11PM +0530, Mukunda,Vijendar wrote: > On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:
> > > static const struct acpi_device_id acp3x_audio_acpi_match[] = { > > > { "AMDI5682", (unsigned long)&acp3x_5682}, > > > { "AMDI1015", (unsigned long)&acp3x_1015}, > > > + { "AMDP1015", (unsigned long)&acp3x_1015p},
> > This isn't a valid ACPI ID. AMDP does not exist in
...
> > There was a similar issue with Intel platforms using this part, we had > > to use a different HID.
> Is it okay if i use "AMDI1016" for ALC1015P?
That's valid, though obviously you might regret that later on if someone releases a CODEC with a 1016 name (equally well ACPI being what it is there's no good options for naming). [unhandled content-type:application/pgp-signature] | |