lkml.org 
[lkml]   [2021]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Fix hibernation in FIPS mode?
From
Date
On 3/30/21 10:46 AM, Rafael J. Wysocki wrote:
> On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui <decui@microsoft.com> wrote:
>> Hi,
>> MD5 was marked incompliant with FIPS in 2009:
>> a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips mode")
>> a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode")
>>
>> But hibernation_e820_save() is still using MD5, and fails in FIPS mode
>> due to the 2018 patch:
>> 749fa17093ff ("PM / hibernate: Check the success of generating md5 digest before hibernation")
>>
>> As a result, hibernation doesn't work when FIPS is on.
>>
>> Do you think if hibernation_e820_save() should be changed to use a
>> FIPS-compliant algorithm like SHA-1?
> I would say yes, it should.


If we're not actually encrypting anything, shouldn't something like
ghash work as well?


>
>> PS, currently it looks like FIPS mode is broken in the mainline:
>> https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg49414.html


\
 
 \ /
  Last update: 2021-03-30 16:53    [W:0.065 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site