lkml.org 
[lkml]   [2021]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct register operations
> > > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro,
> > > + struct sparx5_sd25g28_params *params)
> > > {
> > > - struct sparx5_serdes_regval item[] = {
> >
> > Could you just add const here, and then it is no longer on the stack?
> >
> > Andrew
>
> No it still counts against the stack even as a const structure.

I'm surprised. Maybe it needs static as well?

I'm just thinking you can get a much smaller patch if you don't need
to modify the table, just add additional qualifiers.

Andrew

\
 
 \ /
  Last update: 2021-03-30 15:36    [W:0.045 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site