Messages in this thread | | | Date | Tue, 30 Mar 2021 15:34:24 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct register operations |
| |
> > > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro, > > > + struct sparx5_sd25g28_params *params) > > > { > > > - struct sparx5_serdes_regval item[] = { > > > > Could you just add const here, and then it is no longer on the stack? > > > > Andrew > > No it still counts against the stack even as a const structure.
I'm surprised. Maybe it needs static as well?
I'm just thinking you can get a much smaller patch if you don't need to modify the table, just add additional qualifiers.
Andrew
| |