Messages in this thread | | | Subject | Re: [PATCH v5 2/4] fs: unicode: Rename function names from utf8 to unicode | From | Shreeya Patel <> | Date | Tue, 30 Mar 2021 15:19:37 +0530 |
| |
On 30/03/21 7:23 am, Eric Biggers wrote: > On Tue, Mar 30, 2021 at 02:12:38AM +0530, Shreeya Patel wrote: >> utf8data.h_shipped has a large database table which is an auto-generated >> decodification trie for the unicode normalization functions and it is not >> necessary to carry this large table in the kernel. >> Goal is to make UTF-8 encoding loadable by converting it into a module >> and adding a unicode subsystem layer between the filesystems and the >> utf8 module. >> This layer will load the module whenever any filesystem that >> needs unicode is mounted. >> utf8-core will be converted into this layer file in the future patches, >> hence rename the function names from utf8 to unicode which will denote the >> functions as the unicode subsystem layer functions and this will also be >> the first step towards the transformation of utf8-core file into the >> unicode subsystem layer file. >> >> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com> >> --- >> Changes in v5 >> - Improve the commit message. > This didn't really answer my questions about the reason for this renaming. > Aren't the functions like unicode_casefold() still tied to UTF-8 (as opposed to > e.g. supporting both UTF-8 and UTF-16)? Is that something you're trying to > change?
Currently, layer's functions are still tied to UTF-8 encoding only. But in future if we will have UTF-16 support then layer file would have to be changed accordingly to support both. Unicode subsystem layer is a generic layer which connects the filesystems and UTF8 module ( and/or UTF16 in future )
> > - Eric >
| |