Messages in this thread | | | Date | Tue, 30 Mar 2021 12:27:49 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci_probe() |
| |
On Tue, Mar 30, 2021 at 09:36:59AM +0800, Qiheng Lin wrote: > In case of error, the function pci_iomap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test.
Error path there is broken completely, this is only one place you fix, but I suggest to switch to devm*, pcim* APIs instead,
-- With Best Regards, Andy Shevchenko
| |