lkml.org 
[lkml]   [2021]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci_probe()
On Tue, Mar 30, 2021 at 09:36:59AM +0800, Qiheng Lin wrote:
> In case of error, the function pci_iomap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.

Error path there is broken completely, this is only one place you fix, but I
suggest to switch to devm*, pcim* APIs instead,


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-03-30 11:28    [W:2.164 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site