Messages in this thread | | | Subject | Re: [PATCH] usb: dwc3: exynos: fix incorrect kernel-doc comment syntax | From | Krzysztof Kozlowski <> | Date | Tue, 30 Mar 2021 10:51:15 +0200 |
| |
On 29/03/2021 16:03, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for drivers/usb/dwc3/dwc3-exynos.c follows this syntax, but the > content inside does not comply with kernel-doc. > > This line was probably not meant for kernel-doc parsing, but is parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warning from kernel-doc: > "warning: expecting prototype for dwc3(). Prototype was for DWC3_EXYNOS_MAX_CLOCKS() instead" > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it.
One sentence with error log would be enough for such trivial change. Anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
| |