Messages in this thread | | | Date | Tue, 30 Mar 2021 14:10:35 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v5 5/9] soundwire: qcom: update register read/write routine |
| |
On 26-03-21, 06:39, Srinivas Kandagatla wrote:
> + swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val); > + > + /* version 1.3 or less */ > + if (swrm->version <= 0x01030000) > + usleep_range(150, 155); > + > + if (cmd_id == SWR_BROADCAST_CMD_ID) { > + /* > + * sleep for 10ms for MSM soundwire variant to allow broadcast > + * command to complete. > + */ > + ret = wait_for_completion_timeout(&swrm->broadcast, > + msecs_to_jiffies(TIMEOUT_MS)); > + if (!ret) > + ret = SDW_CMD_IGNORED; > + else > + ret = SDW_CMD_OK; > > - if (!ret) { > - ret = SDW_CMD_IGNORED; > - goto err; > } else { > ret = SDW_CMD_OK; > }
Maybe add a comment here that we dont get status so write is assumed to be OK
-- ~Vinod
| |