Messages in this thread | | | Subject | Re: [PATCH] mm: change size_t to unsigned int for cma_alloc | From | David Hildenbrand <> | Date | Tue, 30 Mar 2021 09:58:37 +0200 |
| |
On 29.03.21 22:12, Minchan Kim wrote: > On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: >> On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: >>> size_t in cma_alloc is confusing since it makes people think >>> it's byte count, not pages. Fix it. >> >> i think it has to be unsigned long. >> >> 67a2e213e7e937c41c52ab5bc46bf3f4de469f6e
Right.
Fortunately, we don't have such large allocations yet via CMA/alloc_contig_range
> > Thanks for the pinter. I wanted to have the smallest change. > The commit leads me to change cma_release, trace_cma_alloc, > cma_clear_bitmap and front_contig_range as well.(Not sure > we have more. Will check). > > Ccing david@redhat.com for upcoming changing free_contig_range.
While at it, we might want to convert free_contig_range() to eat "unsigned long start, unsigned long end" like alloc_contig_range(), instead of "unsigned long pfn, unsigned int nr_pages" like alloc_contig_pages() ...
-- Thanks,
David / dhildenb
| |